Roux Components v1#17
Draft
pangolingo wants to merge 130 commits into
Draft
Conversation
Also started a "sizing" set of utility classes, starting with widths
Uses 11ty to generate a static site for displaying a component library built with Roux.
- Set pathPrefix to /roux/ in production via SITE_ENV variable - Update CSS link to use Eleventy's url filter (to set the path prefix in prod) - Simplify deploy script environment variables
- legend to explain required field asterisks - make radio buttons actually required with attribute - remove space from textarea
The SVG was unlabelled but also redudant. Added title/label but made it aria-hidden
- changed lt/gt symbols to arrows - added aria-labels next/previous to arrows - add role=separator for ellipsis separators
improved labeling and aria-roles
Best practice: added scope="col" to th tags in thead
- fixed invalid separator role inside list - fixed invalid/unnecessary labelledby on aria-hidden item
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges the working Roux Components branch into
main.What this adds:
/sitedirectory).button:disabledstylesblockquotestyles